https://gitlab.synchro.net/main/sbbs/-/commit/8b6210dcaf2e3b49ed16f110
Modified Files:
src/sbbs3/main.cpp
Log Message:
Destroy the nodefile_mutex in sbbs_t destructor

This could've been a small memory leak

Also using [F]CLOSE_OPEN_FILE function-like macros to simplify code

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/819d26b6c593606c3e2e2497
Modified Files:
src/sbbs3/main.cpp
Log Message:
Simplify/correct the node status fixup upon client connect

- when we treat a non-WFC node status the same as WFC because the node_socket
is invalid, don't call lprintf(LOG_CRIT, ...) with the node logged. That's
ultimately going to call errormsg() which is going to try to increment the
node's critical error counter and fail or deadlock because the node's
record is already locked. Log the error after we call putnodedat() and the
node record has been unlocked.
- The "status is WFC" while the node_socket is valid check would always fail
because we already checked the node_socket validity at the top of the loop
so just remove this check/error message as dead code

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/80137a5129d974935681c478
Modified Files:
src/sbbs3/main.cpp
Log Message:
Log the corrected node status value (error caught be GCC printf-validation)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5c099d90d119dd447133160b
Modified Files:
src/sbbs3/main.cpp
Log Message:
Replace break accidentally removed in previous commit

Would mark all nodes as at the prompt up new connection (big whoops)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/783473d285db5e03b445a9fb
Modified Files:
src/sbbs3/main.cpp
Log Message:
Correct node status stuck in "logout" status too (abnormal condition)

"LOGOUT" is another node status where the socket should be valid

Since my Debian 13 (and Samba) upgrade, I've been getting a lot of node.dab
and mail base corruption. Some of these conditions can be auto-corrected and this is one of them.

Removed some obsolete comments about old crash reports.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/43328cad606fde38aec86eea
Modified Files:
src/sbbs3/main.cpp
Log Message:
Fix potential socket leak upon server termination

caught/reported by Claude via Deuce

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6e49cb9c959c7e1710a1ac09
Modified Files:
src/sbbs3/main.cpp
Log Message:
Coverity complained about this unnecessary invalidation of client_socket here

CID 644869

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net